Wikipedia talk:XFDcloser

WT:XFDC

Archives: Index 1, 2, 3, 4, 5, 6

This page has archives. Sections older than 180 days may be automatically archived by when more than 10 sections are present.

Add draftify result?

Tracked in github.com
Issue #68

Can I firstly say, thank you so much Novem Linguae for all your work with patching and bug investigating over the past couple of months - you are an unsung hero!

This is a very greedy wishlist request but I was wondering if there was capacity at some point in the future to add "draftify" as one of the results for AfD? It seems to be a reasonably common outcome nowadays and, while it is eminently achievable by using "custom" and then actioning all the page moves etc., would be amazing for it to be all bundled up. Fully understand if not possible though, or not a priority given everything else happening.

Cheers, Daniel (talk) 13:05, 28 August 2024 (UTC)[reply]

Looks like Vanamonde93 already requested this back in 2022. Ticket. I'll slap a high priority tag on it since it is now requested by multiple people. (This just means that if a volunteer dev ever sits down to work on tickets, hopefully they consider prioritizing it. There's no active development at the moment.) By the way, can you go into a bit more detail about the "extra steps" for drafts? Is the only extra step moving the page to the draft namespace, or are there other steps? Thanks. –Novem Linguae (talk) 13:19, 28 August 2024 (UTC)[reply]

It's late here but to my memory, click 'custom' > type "draftify" > close > go to article > move article (and tick 'move talk page' and 'do not leave redirect') > comment out categories on draft page (could be automated?). The bot adds the 'draft from mainspace' template afterwards. Might be something else? Daniel (talk) 13:25, 28 August 2024 (UTC)[reply]

I feel like a slight tweak of this would actually make it more useful across more circumstances. For example, at TFD there are (not super-often) "userfications" made to templates, where the template is moved to a userspace, similar to a draftification at AFD. It might be worth having a generic "move" option in the closer options, where the closer can choose the new name of the page (e.g. "Example -> Draft:Example" or "Template:Example -> User:Joe/Template:Example") which could do the move-without-redirect. I do recognise that moving pages is a bit more involved than just editing or deleting pages, so if that sort of expanded functionality is too much, then I guess I'll just have to live with it! Primefac (talk) 13:34, 28 August 2024 (UTC)[reply]

Seems like there could be 3 additional modes to add here: AFD draftify, AFD userfy, and TFD userfy. Any others? I'm not sure a move feature would be as useful for things like CFD, RFD, and FFD. Draftify has enough unique stuff going on (turning off categories, adding Moved Draft template) in it that it may make sense to keep it separate. There's also some positives to pre-programming the correct terminology in. For example "draftify" would probably be better to write in an AFD close than "move to Draft:X". –Novem Linguae (talk) 13:57, 28 August 2024 (UTC)[reply]

Just noting that I came here ot ask the same question. This is an amazingly helpful tool, this functionality would just make it that much better. Just Step Sideways ^{from this world ..... today} 01:56, 24 November 2024 (UTC)[reply]

Close log

Tracked in github.com
Issue #94

I think it would be very nice to have the tool automatically keep a close log, like twinkle does for CSD and AfD noms.

Kingsmasher678 (talk) 19:42, 4 December 2024 (UTC)[reply]

Delinking/delisting Bug?

Tracked in github.com
Issue #95

Is this an existing or known bug, shouldn't the script be delinking instead of removing entirely? — Paper9oll (🔔 • 📝) 12:12, 21 December 2024 (UTC)[reply]

The edit summary says "removing links / list items". The "removing list items" part makes it seem like it might be intentionally programmed this way. Interesting. If so, I think just always de-linking might be a bit safer. –Novem Linguae (talk) 13:21, 21 December 2024 (UTC)[reply]

Ya, I think it would be safer to change it do delinking as this wasn't caught until a day later by a new editor. — Paper9oll (🔔 • 📝) 13:26, 21 December 2024 (UTC)[reply]

Header changed to a more descriptive one

Per Wikipedia:XFDcloser#Unlinking_backlinks this is an issue with the closer not pressing the right buttons. In other words, it is not a bug. Primefac (talk) 13:35, 23 December 2024 (UTC)[reply]

Thanks for that link. I didn't realize that each list removal prompted the user to manually approve it. It should be safe to keep this feature.

Closing without action –Novem Linguae (talk) 17:25, 23 December 2024 (UTC)[reply]

Noted, thanks! — Paper9oll (🔔 • 📝) 18:52, 23 December 2024 (UTC)[reply]

Unable to type in Multiple results

Tracked in github.com
Issue #96

I started seeing the problem on Sep 9 or 10 (see WT:Redirects for discussion#XFDcloser is broken), but it may have been there from earlier. Typing into the Result Summary or Rationale fields of the XFDcloser is not possible. It treats characters as keyboard shortcuts and does other stuff. Apparently it happens for Multiple results only. Jay 💬 06:54, 25 September 2022 (UTC)[reply]

Also typing in something in the RCAT page of the wizard messes up the earlier result selections. I typed R and all my results went back to Retarget

. Jay 💬 06:56, 30 September 2022 (UTC)[reply]

@Evad37: Can a bug be filed for this, or maybe revert the September 9-10 change that caused this regression? Jay 💬 11:09, 20 November 2022 (UTC)[reply]

This happens on Firefox which I use. This doesn't happen with Chrome. But today, I see that the Multiple results option is fully broken. The "Next" button is not getting enabled. Jay 💬 08:36, 4 February 2023 (UTC)[reply]

So any time I have to close a RfD with multiple results, I log out of Firefox, log in to Chrome, and do the close.Whatever change was made to this tool in Sep 2022 should be reverted. Jay 💬 13:48, 26 March 2023 (UTC)[reply]

I had this same problem – I had to copy/paste my rationale, etc. from a separate page. When I typed "S", everything went to "Soft redirect". Can someone please fix this? It was quite annoying Edward-Woodrow :) _[talk] 19:58, 14 August 2023 (UTC)[reply]

Ran into this bug again today on Firefox after seemingly not having seen it for a while. _signed,Rosguill ^talk 17:25, 8 October 2023 (UTC)[reply]

Today I closed an RfD where one of the entries was Delete and the other was Retarget, but the delete entry was not actually deleted but retargeted to "null". Jay 💬 14:28, 27 December 2024 (UTC)[reply]

@Jay. Do you think this is still a Firefox-only bug? Were you using Firefox for this particular close? –Novem Linguae (talk) 20:33, 27 December 2024 (UTC)[reply]

Yes, I was using Firefox. I'll use Chrome the next time I have a chance, and update here. Jay 💬 05:48, 28 December 2024 (UTC)[reply]

Toomanyvalues

Tracked in github.com
Issue #60

Can someone please take a look at Wikipedia:Miscellany for deletion/User:HeyDuggeeOfficial2024/sandbox/The Olden Days and tell me if anything can be done to make XFDcloser work? —Alalch E. 21:23, 6 January 2025 (UTC)[reply]

What's the steps to reproduce? Do you just hit close (not quickClose), try to close all as delete, then it gives a "Toomanyvalues" error message in the user interface without doing anything? –Novem Linguae (talk) 22:35, 6 January 2025 (UTC)[reply]

Dou you see the buttons? I didn't click close and. What I see is that the XFDcloser buttons are missing. They show for a fraction of a second and are then replaced by the message "toomanyvalues error retrieving page information (reload the page to try again)". Which is due to too many pages being listed, supposedly. I tried to look what the max number of links is but couldn't find this information. —Alalch E. 22:56, 6 January 2025 (UTC)[reply]

Works for me. Is probably an mw:Action API rate limit error due to not being an admin. This is probably ticket #60. –Novem Linguae (talk) 23:10, 6 January 2025 (UTC)[reply]

As a workaround, maybe have an admin close it on your behalf. If you want, you can give me a close result and rationale, and I'll try to do the close for you, and then we can edit in your signature to the close message. What would you like the result and close rationale to be? –Novem Linguae (talk) 23:20, 6 January 2025 (UTC)[reply]

Oh great, thanks. Everything is fine then. I have no intent of closing. I just started this MfD this way and then became worried about including too many pages basically, "breaking" XFCloser, and causing a potential hassle for an admin who would close. So I posted here to see what's up. —Alalch E. 23:29, 6 January 2025 (UTC)[reply]

I think the admin limit is 500, so should be good :) –Novem Linguae (talk) 23:35, 6 January 2025 (UTC)[reply]

How to automatically remove deleted templates?

I noticed XFDcloser does not automatically remove deleted templates from articles when closing a TfD. Is there an option to do this, or does XFDcloser not yet support this feature? Ixfd64 (talk) 18:53, 2 February 2025 (UTC)[reply]

It's a decent idea, but removing transclusions of a template is not the same as simply unlinking backlinks. WP:TFDH always has entries for templates that need removal, even the simple ones. While yes, there are occasions where straight-forward removal is acceptable (e.g. a navbox being deleted) I do not want to have to clean up after someone who accidentally deletes a template called on thousands of pages that needs either substing, a merge, or replacement. Keep listing things at the holding cell and let people who have the time to do the cleanup take care of it. Primefac (talk) 07:20, 4 February 2025 (UTC)[reply]

Fair enough. I guess I'll stick to the holding cell for the less simple cases. Ixfd64 (talk) 18:52, 4 February 2025 (UTC)[reply]

Closing without action –Novem Linguae (talk) 22:23, 4 February 2025 (UTC)[reply]

TM:Xfd relist swap back to div element

There's an unfortunate selector in the vector-2022 CSS that makes some replies to the TM:Xfd relist overlap text. The selector can be avoided by using <div> rather than <p>. Would making this swap break things? See the section at Template talk:XfD relist#Overlapping Replies for more info. ⇌ Synpath 03:50, 10 February 2025 (UTC)[reply]

Strange article linkage

Let me start by saying this is probably my favorite gadget for Wikipedia. It has always worked perfectly for me until my recent closure of Wikipedia:Articles for deletion/Vingtaine du Rondin. The gadget properly identified links to that article, but also mysteriously identified pages linking Roads in Jersey. I couldn't figure out why those links would be affected by the closing, so I thought I would mention it here. Let me know if I am missing something obvious. Mojo Hand (talk) 16:19, 25 April 2025 (UTC)[reply]

Possibly because the redirect Roads in Jersey had two navboxes, one of which linked to Vingtaine du Rondin. I have since removed the navboxes as they shouldn't appear on redirect pages. I suspect that if you delete an article linked to from a redirect page, then the tool assumes that it redirects to the article being deleted, even if it's not. It's still an error though. —CX Zoom[he/him] ^{(let's talk • {C•X})} 17:57, 25 April 2025 (UTC)[reply]

Tests failing + general question about best venue for technical questions

@Novem Linguae What's the best place to bug you with questions I have about XfD closer? I'm taking a stab at implementing a few of the outstanding issues and it looks like there's a pair of tests failing before I've made any changes, and the talk page seems like a poor fit but so does github. (My main question is whether the GetRelistInfo tests failing is a known issue or represents a likely problem with my setup, but I expect I may have more unless you tell me you're not up for fielding questions about this given then immense number of technical things you're listed as the maintainer for, which would be totally reasonable.) Rusalkii (talk) 21:57, 28 April 2025 (UTC)[reply]

Yeah, this talk page is fine.

CI seems to be passing on GitHub: https://github.com/wikimedia-gadgets/xfdcloser/pulls and https://github.com/wikimedia-gadgets/xfdcloser/commits/master/ (note the green check marks). Are you just doing npm test in localhost? How would I reproduce this if I wanted to help you troubleshoot? –Novem Linguae (talk) 22:10, 28 April 2025 (UTC)[reply]

I cloned it, ran npm run build without making any changes, hit an error (xfdcloser/dist/loader-dev.js no such file or directory), ran npm run test, and got all tests passing except

1) GetRelistInfo
       gets relist wikitexts for TfD:
     TypeError: Cannot add property user, object is not extensible
      at Context.<anonymous> (test/testTaskGetRelistInfo.js:117:3)
      at processImmediate (node:internal/timers:483:21)
2) GetRelistInfo
       gets relist wikitexts for TfD, multiple pages:
     TypeError: Cannot add property user, object is not extensible
      at Context.<anonymous> (test/testTaskGetRelistInfo.js:133:3)
      at processImmediate (node:internal/timers:483:21)

Rusalkii (talk) 22:23, 28 April 2025 (UTC)[reply]

Sorry for the truly cursed formatting, I'm not sure how to do codeblocks properly onwiki. Rusalkii (talk) 22:24, 28 April 2025 (UTC)[reply]

<syntaxhighlight> or <pre> are good for multi-line blocks :) Will try to reproduce this if I get time and let you know what happens. –Novem Linguae (talk) 23:30, 28 April 2025 (UTC)[reply]

Using arrow keys when doing a multi-result close should not change the results

This is extremely frustrating behavior that makes it far more difficult than necessary to write/edit a long rationale. Elli (talk | contribs) 19:41, 3 May 2025 (UTC)[reply]

See #Unable to type in Multiple results. This has been there from September 2022, and whatever changes were made that created the bug were never reverted. Are you using Firefox? Jay 💬 20:19, 3 May 2025 (UTC)[reply]